Skip to content

Comments

V4 support beta#418

Open
liquid-8 wants to merge 42 commits intomasterfrom
dev/v4-fin
Open

V4 support beta#418
liquid-8 wants to merge 42 commits intomasterfrom
dev/v4-fin

Conversation

@liquid-8
Copy link
Member

Basic functionality, like price fetching, quoting, and making simple swaps etc

@liquid-8 liquid-8 linked an issue Jan 5, 2026 that may be closed by this pull request
Pool manager contract ABI
Liquidity pools list management class added, UniswapV4 improvements.
Copy link
Member

@ErikBjare ErikBjare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally approved. Haven't checked why CI is failing yet.

Could use some auto-formatting by ruff.

@ErikBjare
Copy link
Member

Ah, I see CI is failing due to outdated actions. I think we can merge this and address the outdated CI and any CI issues related to this PR in follow-up.

moved to constants
Structure refactoring; fixes; StateView contract support added
@liquid-8 liquid-8 requested a review from ErikBjare February 17, 2026 00:17
@liquid-8 liquid-8 self-assigned this Feb 17, 2026
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strange that this diff became so messy

Copy link
Member

@ErikBjare ErikBjare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, better structure!

I think it would be worthwhile to add a proper pre-commit/prek config with ruff and ruff-format though, would probably fix the weird diffs that suggest a lot more has changed than it has.

@liquid-8 liquid-8 requested a review from ErikBjare February 17, 2026 21:08
@liquid-8
Copy link
Member Author

Nice, better structure!

I think it would be worthwhile to add a proper pre-commit/prek config with ruff and ruff-format though, would probably fix the weird diffs that suggest a lot more has changed than it has.

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Uniswap v4 support

2 participants