Skip to content

Fix numpy_num_face_vertices() #408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
paulmelnikow wants to merge 4 commits into
base: upgrade-cibw
Choose a base branch
from
Open

Fix numpy_num_face_vertices() #408

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
03cfda8
Match the types and call buf.release()
paulmelnikow Feb 20, 2026
2296782
Rm buf.release()
paulmelnikow Feb 20, 2026
a027b25
Merge branch 'upgrade-cibw' into numpy-fixes
paulmelnikow Feb 20, 2026
0101956
Merge branch 'upgrade-cibw' into numpy-fixes
paulmelnikow Feb 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions python/bindings.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,9 +149,9 @@ PYBIND11_MODULE(tinyobjloader, tobj_module)
.def(py::init<>())
.def_readonly("num_face_vertices", &mesh_t::num_face_vertices)
.def("numpy_num_face_vertices", [] (mesh_t &instance) {
auto ret = py::array_t<unsigned char>(instance.num_face_vertices.size());
auto ret = py::array_t<unsigned int>(instance.num_face_vertices.size());
py::buffer_info buf = ret.request();
memcpy(buf.ptr, instance.num_face_vertices.data(), instance.num_face_vertices.size() * sizeof(unsigned char));
memcpy(buf.ptr, instance.num_face_vertices.data(), instance.num_face_vertices.size() * sizeof(unsigned int));
return ret;
})
.def("vertex_indices", [](mesh_t &self) {
Expand Down
Loading