Jetty: apply shutdown idle timeout for graceful shutdown#49278
Open
l2yujw wants to merge 1 commit intospring-projects:mainfrom
Open
Jetty: apply shutdown idle timeout for graceful shutdown#49278l2yujw wants to merge 1 commit intospring-projects:mainfrom
l2yujw wants to merge 1 commit intospring-projects:mainfrom
Conversation
Signed-off-by: l2yuPa <jeungwon28@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves the Jetty connector shutdown idle timeout configuration from a
test-only customizer into main code when graceful shutdown is enabled.
Rationale
The Jetty servlet web server tests currently set
shutdownIdleTimeoutvia acustomizer and include a TODO to configure it in main code. Keeping this as a
test-only workaround can lead to inconsistent behavior for users relying on
graceful shutdown.
Changes
shutdownIdleTimeoutto JettyServerConnectors whenShutdown.GRACEFULis enabledTesting
./gradlew :module:spring-boot-jetty:test