gh-145031: suggest the module in "python -m module"#145096
Open
Locked-chess-official wants to merge 7 commits intopython:mainfrom
Open
gh-145031: suggest the module in "python -m module"#145096Locked-chess-official wants to merge 7 commits intopython:mainfrom
Locked-chess-official wants to merge 7 commits intopython:mainfrom
Conversation
aisk
reviewed
Feb 22, 2026
Misc/NEWS.d/next/Library/2026-02-22-12-39-31.gh-issue-145031.-4yezd.rst
Outdated
Show resolved
Hide resolved
aisk
reviewed
Feb 22, 2026
Co-authored-by: AN Long <aisk@users.noreply.github.com>
picnixz
reviewed
Feb 22, 2026
| raise error("No module named %s" % mod_name) | ||
| message = "No module named %r" % mod_name | ||
| if (d := _get_possible_name_list(mod_name)): | ||
| from traceback import _calculate_closed_name |
Member
There was a problem hiding this comment.
Now we don't need to use local imports to defer imports, we can just use lazy imports.
Contributor
Author
There was a problem hiding this comment.
I don't think that using new feature in frozen modules is a good idea. If global lazy imports have some bugs, the users just download the release version will unable to be avoid of it. The lazy imports are more suitable to be in the normal modules.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To reduce the code, I split the function
traceback._compute_suggestion_error