Open
Conversation
Signed-off-by: Anatol Belski <ab@php.net>
The xxHash 0.8.3 upgrade renamed the `memsize` member to `bufferedSize` in XXH32_state_s and XXH64_state_s. Signed-off-by: Anatol Belski <ab@php.net>
Member
|
For reference: #20064 (comment) |
Signed-off-by: Anatol Belski <ab@php.net>
Author
Thanks for the heads up! I looked into the serialization concern from #20064. The struct changes in 0.8.3 are renames and type reinterpretations only - the binary layout is identical. Added a backward compat test that can be executed on earlier versions and to ensure future compatibility. Thanks |
ndossche
approved these changes
Feb 22, 2026
Member
ndossche
left a comment
There was a problem hiding this comment.
I did the following checks:
- Ran with ASAN/UBSAN
- Checked the test
- Checked code changes in ext/hash
- Checked the diff against upstream xxhash 0.8.3, clean diff.
TimWolla
approved these changes
Feb 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the bundled xxHash library to 0.8.3 and adapts the renamed struct members.