[WIP] diagnostics_channel: add meta buil-in channels#61943
Draft
simon-id wants to merge 1 commit intonodejs:mainfrom
Draft
[WIP] diagnostics_channel: add meta buil-in channels#61943simon-id wants to merge 1 commit intonodejs:mainfrom
simon-id wants to merge 1 commit intonodejs:mainfrom
Conversation
Signed-off-by: simon-id <simon.id@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This add DC (
diagnostics_channel) built-in events, for DC itself. Just likehttp,console, orprocess, have built-in events that can be subscribed to, to monitor code, this make it possible for DC to be monitored through DC.Why
It appeared that multiple people working with DC channels extensively ended up monkey-patching DC in their test app or test suite, to allow some actions to be logged. Now instead of monkey-patching, they can just listen to these events.
It also allows one to create a kind of "dead-letter queue" DC subscription, that will catch all events that were not delivered: