feat: Add --base-href support to flutter run for web#182709
Open
Mastersam07 wants to merge 3 commits intoflutter:masterfrom
Open
feat: Add --base-href support to flutter run for web#182709Mastersam07 wants to merge 3 commits intoflutter:masterfrom
Mastersam07 wants to merge 3 commits intoflutter:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds support for the --base-href flag to the flutter run command for web targets, which is a valuable addition for developers testing applications in subfolders. The implementation correctly handles template substitution and server routing. I've noted a few improvements: ensuring the value is also read from the configuration file, adding the missing parsing logic in WebDevServerConfig.fromYaml, and using existing utility functions for cleaner string manipulation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
--base-hrefsupport to theflutter runcommand for web targets.Previously,
--base-hrefwas only available onflutter build web, which meant developers testing web apps hosted in subfolders had to manually editweb/index.htmlduring development and undo the change before committing. This PR brings the same flag toflutter run, so the dev server correctly serves the app with a custom base path.Usage
The value must start and end with
/, matching the same validation asflutter build web --base-href.Fixes #163141
Pre-launch Checklist
///).