Open
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request successfully removes the unused getPluginDependencies() method and its associated TODO comment from PluginHandler.kt. This change improves code maintainability and clarity by eliminating dead code, aligning with the principle of "Write what you need and no more" from the repository's style guide. The removal of the TODO comment also signifies the completion of a planned refactoring task.
I am having trouble creating individual review comments. Click here to see my feedback.
packages/flutter_tools/gradle/src/main/kotlin/plugins/PluginHandler.kt (59-60)
The removal of this TODO comment indicates that the task to remove getPluginDependencies in favor of getPluginList has been successfully completed. This improves code clarity by removing outdated comments and dead code, enhancing maintainability.
References
- Code should be optimized for readability and should only contain what is needed. Removing outdated TODOs and dead code contributes to this. (link)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For context see :
PRs that removed support :
FlutterProject.flutterPluginsFile. #169897--explicit-package-dependencies. #169950Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.