fix: Check duplicate names for feature view across types#5999
Open
Prathap-P wants to merge 4 commits intofeast-dev:masterfrom
Open
fix: Check duplicate names for feature view across types#5999Prathap-P wants to merge 4 commits intofeast-dev:masterfrom
Prathap-P wants to merge 4 commits intofeast-dev:masterfrom
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Signed-off-by: Prathap P <436prathap@gmail.com>
f23ff7b to
77cc24c
Compare
Signed-off-by: Prathap P <436prathap@gmail.com>
77cc24c to
c299a71
Compare
Signed-off-by: Prathap P <436prathap@gmail.com>
HaoXuAI
reviewed
Feb 22, 2026
|
|
||
| # Check StreamFeatureView before FeatureView since StreamFeatureView is a subclass | ||
| # Note: All getters raise FeatureViewNotFoundException (not type-specific exceptions) | ||
| if isinstance(feature_view, StreamFeatureView): |
Collaborator
There was a problem hiding this comment.
Does this mean it will call to retrieve feature view many times? Can we optimize it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
get_online_featuresresolved feature view names viaget_any_feature_view, which checks registry tables in a fixed order: FeatureView → StreamFeatureView → OnDemandFeatureView.Which issue(s) this PR fixes:
Fixes #5995
Misc