Skip to content

Comments

fix: Add https readiness check for rest-registry tests#5978

Merged
ntkathole merged 1 commit intofeast-dev:masterfrom
ntkathole:wait_rest
Feb 23, 2026
Merged

fix: Add https readiness check for rest-registry tests#5978
ntkathole merged 1 commit intofeast-dev:masterfrom
ntkathole:wait_rest

Conversation

@ntkathole
Copy link
Member

@ntkathole ntkathole commented Feb 17, 2026 •
edited by devin-ai-integration bot
Loading

What this PR does / why we need it:

This PR adds an HTTP readiness poll to the test fixture in sdk/python/tests/integration/registration/rest_api/test_registry_rest_api.py. It poll the HTTP endpoint until it returns a non-502 response.

Which issue(s) this PR fixes:

Fixes #5977

Open with Devin

@ntkathole ntkathole self-assigned this Feb 17, 2026
@ntkathole ntkathole requested a review from a team as a code owner February 17, 2026 11:06
devin-ai-integration[bot]
devin-ai-integration bot reviewed Feb 17, 2026
View reviewed changes
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 2 additional findings.

Open in Devin Review

@ntkathole
Copy link
Member Author

ntkathole commented Feb 17, 2026

Logs from run:

Waiting for HTTP endpoint to become ready (timeout=120s): http://feast.kind.test/api/v1/projects
 HTTP endpoint is ready (status=200)

 Connected to Feast REST at: http://feast.kind.test/

@soooojinlee soooojinlee mentioned this pull request Feb 17, 2026
Open
@ntkathole ntkathole force-pushed the wait_rest branch 3 times, most recently from 880c126 to 46fc952 Compare February 19, 2026 05:56
@ntkathole
Copy link
Member Author

ntkathole commented Feb 19, 2026

@franciscojavierarceo ^

@ntkathole
fix: Add https readiness check for rest-registry tests
b39f091 
Signed-off-by: ntkathole <nikhilkathole2683@gmail.com>
@ntkathole ntkathole merged commit ea85e63 into feast-dev:master Feb 23, 2026
21 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devin-ai-integration devin-ai-integration[bot] devin-ai-integration[bot] left review comments

@franciscojavierarceo franciscojavierarceo franciscojavierarceo approved these changes

Assignees

@ntkathole ntkathole

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

registry-rest-api-tests CI workflow sometimes fails due to missing HTTP readiness check

2 participants

@ntkathole @franciscojavierarceo