fix(qdrant): fix non-class type fields#1752
Merged
JoanFM merged 1 commit intodocarray:mainfrom Aug 13, 2023
Merged
Conversation
Signed-off-by: TERBOUCHE Hacene <hacene.terbouche@gmail.com>
6 tasks
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1752 +/- ##
==========================================
- Coverage 84.31% 79.45% -4.87%
==========================================
Files 134 134
Lines 8842 8842
==========================================
- Hits 7455 7025 -430
- Misses 1387 1817 +430
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
JoanFM
approved these changes
Aug 13, 2023
Member
JoanFM
left a comment
There was a problem hiding this comment.
The failing tests are not due to this PR
Member
|
Thanks a lot for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Resolved: Issue with Defining Index of Type
QdrantDocumentIndexfor Documents with Non-Class Type FieldsDescription:
This pull request addresses the issue where defining an index of type
QdrantDocumentIndexfor documents containing fields with non-class types resulted in aTypeError. The issue has been resolved by replacing the usage ofissubclasswithsafe_issubclass