fix: collection and index name in qdrant#1723
Merged
jupyterjazz merged 1 commit intomainfrom Jul 24, 2023
Merged
Conversation
49c4263 to
c489f90
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1723 +/- ##
==========================================
+ Coverage 85.55% 85.56% +0.01%
==========================================
Files 133 133
Lines 8585 8592 +7
==========================================
+ Hits 7345 7352 +7
Misses 1240 1240
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
c489f90 to
74adf33
Compare
6 tasks
Signed-off-by: Joan Fontanals Martinez <joan.martinez@jina.ai>
74adf33 to
ad8ab1e
Compare
|
📝 Docs are deployed on https://ft-fix-qdrant-index-collection--jina-docs.netlify.app 🎉 |
jupyterjazz
reviewed
Jul 24, 2023
Contributor
jupyterjazz
left a comment
There was a problem hiding this comment.
I don't understand why this change was needed, can you add some context?
Member
Author
|
Check the issue and the test. The 0.36.0 version does not work. The |
jupyterjazz
approved these changes
Jul 24, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The subindex is initialized with a different_index name, so we need to make sure that the collection name is updated accordingly in the constructor.