Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a5447c5ced
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| /> | ||
| <Badge key={itemIds[index]} size="sm" className="gap-1 pr-1"> | ||
| {value} | ||
| <Button |
There was a problem hiding this comment.
Move remove buttons out of the wrapping label
Placing each remove <Button> inside the same <label> that owns the text <input> introduces an extra labelable control inside a label, which is invalid HTML and can cause inconsistent focus/announcement behavior for keyboard and screen-reader users (the label activation competes with the button interaction). This regression was introduced by replacing Chip with a real <button> element, so the remove action should be rendered outside the label wrapper (or the input should be associated via htmlFor) to keep semantics stable.
Useful? React with 👍 / 👎.
This pull-request removes the last instance of
@mui/material/Chipfrom the codebase. And removes it from ourvite.config.mtsso we no longer have to cache it 🙂