Skip to content

Comments

refactor(common): log a warning when a KeyValuePipe receives a signal#67184

Open
SkyZeroZx wants to merge 1 commit intoangular:mainfrom
SkyZeroZx:refactor/pipe-warning
Open

refactor(common): log a warning when a KeyValuePipe receives a signal#67184
SkyZeroZx wants to merge 1 commit intoangular:mainfrom
SkyZeroZx:refactor/pipe-warning

Conversation

@SkyZeroZx
Copy link
Contributor

@SkyZeroZx SkyZeroZx commented Feb 20, 2026

Add signal warning for KeyValuePipe and consolidates the invalidPipeArgumentError function into a utils

Inspired by #66993

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.dev application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

@Component({
 template: `
   @for (item of jsonObject | keyvalue; track item.key) { // It never fails and works quietly
     <div>{{ item.key }}:{{ item.value }}</div> 
   }
 `,
 imports: [KeyValuePipe],
})
export class Dummy {
 jsonObject = signal({ name: 'Angular', version: 'v21' });
}

What is the new behavior?

A warning similar to JsonPipe is added

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Add signal warning for `KeyValuePipe` and consolidates the `invalidPipeArgumentError` function into a `utils`
@pullapprove pullapprove bot requested a review from crisbeto February 20, 2026 22:23
@angular-robot angular-robot bot added the area: common Issues related to APIs in the @angular/common package label Feb 20, 2026
@ngbot ngbot bot added this to the Backlog milestone Feb 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: common Issues related to APIs in the @angular/common package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant