refactor(forms): restrict reactive logic to a readonly API#67161
Draft
leonsenft wants to merge 3 commits intoangular:mainfrom
Draft
refactor(forms): restrict reactive logic to a readonly API#67161leonsenft wants to merge 3 commits intoangular:mainfrom
leonsenft wants to merge 3 commits intoangular:mainfrom
Conversation
* Remove unused `TValue` type parameter from `FormUiControl` * Remove unused imports * Remove unnecessary cast
fa08c90 to
a556ad2
Compare
a556ad2 to
e816fd3
Compare
14 tasks
e816fd3 to
18a7682
Compare
Contributor
Author
|
Splitting the first cleanup commit out into its own PR while I iterate on this one: #67182. |
Reactive logic in forms is not intended to mutate state, but this was poorly communicated by the permissive and highly mutable field context provided to all logic functions. This change splits all of the state-related API into writable and readonly interfaces. * Top-level functions that produce a `FieldTree` (e.g. `form()`) expose writable signals (e.g. `value: WritableSignal<T>`) and mutating methods (e.g. `markAsDirty()`). * Reactive logic expose readonly signals (e.g. `value: Signal<T>`) and omit mutating methods.
Introduce `FormFieldBinding` to represent a binding between a field and a UI control through a `FormField` directive. This interface is used to restrict `SignalFormsConfig` and `formFieldBindings` to a readonly API. Fix angular#65779.
18a7682 to
88b8866
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reactive logic in forms is not intended to mutate state, but this was poorly communicated by the permissive and highly mutable field context provided to all logic functions. This change splits all of the state-related API into writable and readonly interfaces.
Top-level functions that produce a
FieldTree(e.g.form()) expose writable signals (e.g.value: WritableSignal<T>) and mutating methods (e.g.markAsDirty()).Reactive logic expose readonly signals (e.g.
value: Signal<T>) and omit mutating methods.Fix #65779.